]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
ALSA: aoa: i2sbus: use DECLARE_COMPLETION_ONSTACK() macro
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Wed, 2 Sep 2020 21:21:24 +0000 (16:21 -0500)
committerTakashi Iwai <tiwai@suse.de>
Thu, 3 Sep 2020 07:26:52 +0000 (09:26 +0200)
Follow recommendation in Documentation/scheduler/completion.rst and
use macro to declare local 'struct completion'

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200902212133.30964-10-pierre-louis.bossart@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/aoa/soundbus/i2sbus/pcm.c

index d350dbd2430510f0593fa9d6b58aed9e3a3cd259..1c8e8131a7162c1cb7d8ac159c9e6c79164fa75c 100644 (file)
@@ -254,12 +254,11 @@ static void i2sbus_wait_for_stop(struct i2sbus_dev *i2sdev,
                                 struct pcm_info *pi)
 {
        unsigned long flags;
-       struct completion done;
+       DECLARE_COMPLETION_ONSTACK(done);
        long timeout;
 
        spin_lock_irqsave(&i2sdev->low_lock, flags);
        if (pi->dbdma_ring.stopping) {
-               init_completion(&done);
                pi->stop_completion = &done;
                spin_unlock_irqrestore(&i2sdev->low_lock, flags);
                timeout = wait_for_completion_timeout(&done, HZ);