]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
gpio: dwapb: use dwapb_read instead of readl_relaxed
authorJisheng Zhang <jszhang@marvell.com>
Thu, 13 Apr 2017 09:46:39 +0000 (17:46 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 24 Apr 2017 13:08:53 +0000 (15:08 +0200)
Commit 67809b974a07 ("GPIO: gpio-dwapb: Change readl&writel to
dwapb_read&dwapb_write") missed this readl_relaxed() usage, I'm not
sure the reason, maybe for performance reason? But if we do care
the performance, we could use the relaxed io in dwapb_read and
dwapb_write.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-dwapb.c

index 53ade0b69f497a21873e50d422845455e0d8b636..f051c4552af570257b92bf5d7f80b2a706cbf721 100644 (file)
@@ -164,7 +164,7 @@ static void dwapb_toggle_trigger(struct dwapb_gpio *gpio, unsigned int offs)
 
 static u32 dwapb_do_irq(struct dwapb_gpio *gpio)
 {
-       u32 irq_status = readl_relaxed(gpio->regs + GPIO_INTSTATUS);
+       u32 irq_status = dwapb_read(gpio, GPIO_INTSTATUS);
        u32 ret = irq_status;
 
        while (irq_status) {