]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
net: rtnl_configure_link: fix dev flags changes arg to __dev_notify_flags
authorRoopa Prabhu <roopa@cumulusnetworks.com>
Wed, 12 Sep 2018 20:21:48 +0000 (13:21 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 13 Sep 2018 18:01:32 +0000 (11:01 -0700)
This fix addresses https://bugzilla.kernel.org/show_bug.cgi?id=201071

Commit 5025f7f7d506 wrongly relied on __dev_change_flags to notify users of
dev flag changes in the case when dev->rtnl_link_state = RTNL_LINK_INITIALIZED.
Fix it by indicating flag changes explicitly to __dev_notify_flags.

Fixes: 5025f7f7d506 ("rtnetlink: add rtnl_link_state check in rtnl_configure_link")
Reported-By: Liam mcbirnie <liam.mcbirnie@boeing.com>
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/rtnetlink.c

index 60c928894a7868e5f1bcec39f5204eba9e0fe82f..63ce2283a456a4aeabf3c10b681fe63195209101 100644 (file)
@@ -2810,7 +2810,7 @@ int rtnl_configure_link(struct net_device *dev, const struct ifinfomsg *ifm)
        }
 
        if (dev->rtnl_link_state == RTNL_LINK_INITIALIZED) {
-               __dev_notify_flags(dev, old_flags, 0U);
+               __dev_notify_flags(dev, old_flags, (old_flags ^ dev->flags));
        } else {
                dev->rtnl_link_state = RTNL_LINK_INITIALIZED;
                __dev_notify_flags(dev, old_flags, ~0U);