]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
tpm: xen-tpmfront: Fix default durations
authorJason Gunthorpe <jgunthorpe@obsidianresearch.com>
Mon, 23 Sep 2013 18:14:33 +0000 (12:14 -0600)
committerKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Tue, 24 Sep 2013 20:14:55 +0000 (16:14 -0400)
All the default durations were being set to 10 minutes which is
way too long for the timeouts. Normal values for the longest
duration are around 5 mins, and short duration ar around .5s.

Further, these are just the default, tpm_get_timeouts will set
them to values from the TPM (or throw an error).

Just remove them.

Acked-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
drivers/char/tpm/xen-tpmfront.c

index 7a7929ba26588dbf07d014bf8bb3cf8f55da509a..6f2fe2b0ae56594147a38a0cc9f088784406f276 100644 (file)
@@ -210,8 +210,6 @@ static struct attribute_group vtpm_attr_grp = {
        .attrs = vtpm_attrs,
 };
 
-#define TPM_LONG_TIMEOUT   (10 * 60 * HZ)
-
 static const struct tpm_vendor_specific tpm_vtpm = {
        .status = vtpm_status,
        .recv = vtpm_recv,
@@ -224,11 +222,6 @@ static const struct tpm_vendor_specific tpm_vtpm = {
        .miscdev = {
                .fops = &vtpm_ops,
        },
-       .duration = {
-               TPM_LONG_TIMEOUT,
-               TPM_LONG_TIMEOUT,
-               TPM_LONG_TIMEOUT,
-       },
 };
 
 static irqreturn_t tpmif_interrupt(int dummy, void *dev_id)