]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
Input: sidewinder - mark expected switch fall-throughs
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Fri, 10 Nov 2017 18:23:35 +0000 (10:23 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 10 Nov 2017 18:29:55 +0000 (10:29 -0800)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 114763
Addresses-Coverity-ID: 114764
Addresses-Coverity-ID: 114765
Addresses-Coverity-ID: 114766
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/joystick/sidewinder.c

index 4a95b224169f33f32fbc106a97add8a5b62e141b..5e602a6852b7e65e32ad07e6e616a0a8d393182c 100644 (file)
@@ -672,16 +672,16 @@ static int sw_connect(struct gameport *gameport, struct gameport_driver *drv)
 
                        switch (i * m) {
                                case 60:
-                                       sw->number++;
+                                       sw->number++;                   /* fall through */
                                case 45:                                /* Ambiguous packet length */
                                        if (j <= 40) {                  /* ID length less or eq 40 -> FSP */
                                case 43:
                                                sw->type = SW_ID_FSP;
                                                break;
                                        }
-                                       sw->number++;
+                                       sw->number++;                   /* fall through */
                                case 30:
-                                       sw->number++;
+                                       sw->number++;                   /* fall through */
                                case 15:
                                        sw->type = SW_ID_GP;
                                        break;
@@ -697,9 +697,9 @@ static int sw_connect(struct gameport *gameport, struct gameport_driver *drv)
                                                sw->type = SW_ID_PP;
                                        break;
                                case 66:
-                                       sw->bits = 3;
+                                       sw->bits = 3;                   /* fall through */
                                case 198:
-                                       sw->length = 22;
+                                       sw->length = 22;                /* fall through */
                                case 64:
                                        sw->type = SW_ID_3DP;
                                        if (j == 160)