]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
x86/intel_rdt: Remove redundant ternary operator on return
authorColin Ian King <colin.king@canonical.com>
Tue, 8 Aug 2017 09:28:59 +0000 (10:28 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 16 Aug 2017 14:20:55 +0000 (16:20 +0200)
The use of the ternary operator is redundant as ret can never be
non-zero at that point. Instead, just return nbytes.

Detected by CoverityScan, CID#1452658 ("Logically dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Vikas Shivappa <vikas.shivappa@linux.intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: kernel-janitors@vger.kernel.org
Link: http://lkml.kernel.org/r/20170808092859.13021-1-colin.king@canonical.com
arch/x86/kernel/cpu/intel_rdt_rdtgroup.c

index b529f93e8ed0990fc6c864dc2222646eaae9b51d..a869d4a073c5ced61e19977eccaa94cf8891e208 100644 (file)
@@ -680,7 +680,7 @@ static ssize_t max_threshold_occ_write(struct kernfs_open_file *of,
 
        intel_cqm_threshold = bytes / r->mon_scale;
 
-       return ret ?: nbytes;
+       return nbytes;
 }
 
 /* rdtgroup information files for one cache resource. */