]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commitdiff
clk: cdce925: Fix limit check
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 11 Nov 2016 21:49:05 +0000 (22:49 +0100)
committerStephen Boyd <sboyd@codeaurora.org>
Fri, 9 Dec 2016 00:29:36 +0000 (16:29 -0800)
It is likely that instead of '1>64', 'q>64' was expected.

Moreover, according to datasheet,
   http://www.ti.com/lit/ds/symlink/cdce925.pdf
   SCAS847I - JULY 2007 - REVISED OCTOBER 2016
PLL settings limits are: 16 <= q <= 63
So change the upper limit check from 64 to 63.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
drivers/clk/clk-cdce925.c

index b8459c14a1b7245855a4b91eba0783da0cbf3d6d..f793b2d9238cea8df7d135e3a2d4fcbe20a37da4 100644 (file)
@@ -216,7 +216,7 @@ static int cdce925_pll_prepare(struct clk_hw *hw)
                nn = n * BIT(p);
                /* q = int(nn/m) */
                q = nn / m;
-               if ((q < 16) || (1 > 64)) {
+               if ((q < 16) || (q > 63)) {
                        pr_debug("%s invalid q=%d\n", __func__, q);
                        return -EINVAL;
                }