]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
scsi: qedf: Fixup unnecessary parantheses around test_bit operations.
authorChad Dupuis <chad.dupuis@cavium.com>
Wed, 31 May 2017 13:33:58 +0000 (06:33 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 13 Jun 2017 00:48:06 +0000 (20:48 -0400)
Signed-off-by: Chad Dupuis <chad.dupuis@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qedf/qedf_els.c
drivers/scsi/qedf/qedf_io.c

index 69a365da38916d76db77efab5259c455a8033728..eb07f1de8afa5316be9c038b881d076327c36bb3 100644 (file)
@@ -44,7 +44,7 @@ static int qedf_initiate_els(struct qedf_rport *fcport, unsigned int op,
                goto els_err;
        }
 
-       if (!(test_bit(QEDF_RPORT_SESSION_READY, &fcport->flags))) {
+       if (!test_bit(QEDF_RPORT_SESSION_READY, &fcport->flags)) {
                QEDF_ERR(&(qedf->dbg_ctx), "els 0x%x: fcport not ready\n", op);
                rc = -EINVAL;
                goto els_err;
@@ -225,7 +225,7 @@ int qedf_send_rrq(struct qedf_ioreq *aborted_io_req)
        fcport = aborted_io_req->fcport;
 
        /* Check that fcport is still offloaded */
-       if (!(test_bit(QEDF_RPORT_SESSION_READY, &fcport->flags))) {
+       if (!test_bit(QEDF_RPORT_SESSION_READY, &fcport->flags)) {
                QEDF_ERR(NULL, "fcport is no longer offloaded.\n");
                return -EINVAL;
        }
@@ -550,7 +550,7 @@ static int qedf_send_srr(struct qedf_ioreq *orig_io_req, u32 offset, u8 r_ctl)
        fcport = orig_io_req->fcport;
 
        /* Check that fcport is still offloaded */
-       if (!(test_bit(QEDF_RPORT_SESSION_READY, &fcport->flags))) {
+       if (!test_bit(QEDF_RPORT_SESSION_READY, &fcport->flags)) {
                QEDF_ERR(NULL, "fcport is no longer offloaded.\n");
                return -EINVAL;
        }
index db160046f3e09c35a4585b20fe1fae591a1612cc..ea37c78418d76f7d1f8d284f6b15f4634554a0be 100644 (file)
@@ -1847,7 +1847,7 @@ static int qedf_execute_tmf(struct qedf_rport *fcport, struct scsi_cmnd *sc_cmd,
                return FAILED;
        }
 
-       if (!(test_bit(QEDF_RPORT_SESSION_READY, &fcport->flags))) {
+       if (!test_bit(QEDF_RPORT_SESSION_READY, &fcport->flags)) {
                QEDF_ERR(&(qedf->dbg_ctx), "fcport not offloaded\n");
                rc = FAILED;
                return FAILED;