]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
cxgb4vf: Call netif_carrier_off properly in pci_probe
authorArjun Vynipadath <arjun@chelsio.com>
Fri, 1 Mar 2019 10:37:01 +0000 (16:07 +0530)
committerDavid S. Miller <davem@davemloft.net>
Sat, 2 Mar 2019 07:21:06 +0000 (23:21 -0800)
netif_carrier_off() should be called only after register_netdev().

Signed-off-by: Arjun Vynipadath <arjun@chelsio.com>
Signed-off-by: Vishal Kulkarni <vishal@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c

index 62fd1250ff7ecfd7e27addbf9907554988426325..adc4d481815ba90c228ef851bcd0d71408c767fb 100644 (file)
@@ -3136,7 +3136,6 @@ static int cxgb4vf_pci_probe(struct pci_dev *pdev,
                 * it.
                 */
                pi->xact_addr_filt = -1;
-               netif_carrier_off(netdev);
                netdev->irq = pdev->irq;
 
                netdev->hw_features = NETIF_F_SG | TSO_FLAGS | NETIF_F_GRO |
@@ -3259,6 +3258,7 @@ static int cxgb4vf_pci_probe(struct pci_dev *pdev,
                        continue;
                }
 
+               netif_carrier_off(netdev);
                set_bit(pidx, &adapter->registered_device_map);
        }
        if (adapter->registered_device_map == 0) {