]> git.proxmox.com Git - ovs.git/commitdiff
netdev-windows: fix ofpbuf initialization
authorAlin Serdean <aserdean@cloudbasesolutions.com>
Thu, 27 Oct 2016 19:20:01 +0000 (19:20 +0000)
committerGurucharan Shetty <guru@ovn.org>
Fri, 4 Nov 2016 15:06:50 +0000 (08:06 -0700)
ofpbuf_const_initializer takes only two parameters see:

https://github.com/openvswitch/ovs/blob/master/include/openvswitch/ofpbuf.h#L96

the compiler only gives the following warning:

lib/netdev-windows.c(229) : warning C4020: 'ofpbuf_const_initializer' :
too many actual parameters

which in result will put junk data into "ofpbuf b".

This patch fixes the initialization.

Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
Acked-by: Sairam Venugopal <vsairam@vmware.com>
Signed-off-by: Gurucharan Shetty <guru@ovn.org>
lib/netdev-windows.c

index 32184906d70fe66813c099ecaab675cec8bb715c..423a00b41f99272686b4198f3d27b0632e2888ec 100644 (file)
@@ -226,7 +226,7 @@ netdev_windows_netdev_from_ofpbuf(struct netdev_windows_netdev_info *info,
 
     netdev_windows_info_init(info);
 
-    struct ofpbuf b = ofpbuf_const_initializer(&b, buf->data, buf->size);
+    struct ofpbuf b = ofpbuf_const_initializer(buf->data, buf->size);
     struct nlmsghdr *nlmsg = ofpbuf_try_pull(&b, sizeof *nlmsg);
     struct genlmsghdr *genl = ofpbuf_try_pull(&b, sizeof *genl);
     struct ovs_header *ovs_header = ofpbuf_try_pull(&b, sizeof *ovs_header);