]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
drm/bridge: tfp410: Set input_bus_flags in atomic_check
authorNikhil Devshatwar <nikhil.nd@ti.com>
Tue, 6 Jun 2023 08:21:36 +0000 (13:51 +0530)
committerJavier Martinez Canillas <javierm@redhat.com>
Mon, 10 Jul 2023 12:21:01 +0000 (14:21 +0200)
input_bus_flags are specified in drm_bridge_timings (legacy) as well
as drm_bridge_state->input_bus_cfg.flags

The flags from the timings will be deprecated. Bridges are supposed
to validate and set the bridge state flags from atomic_check.

Implement atomic_check hook for the same.

Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230606082142.23760-3-a-bhatia1@ti.com
drivers/gpu/drm/bridge/ti-tfp410.c

index 60960493afe708dfc1c3a14f78ce8f225076d568..22b07260a78e32e7c9c2bfb1830b6e8dc78fd843 100644 (file)
@@ -228,6 +228,22 @@ static u32 *tfp410_get_input_bus_fmts(struct drm_bridge *bridge,
        return input_fmts;
 }
 
+static int tfp410_atomic_check(struct drm_bridge *bridge,
+                              struct drm_bridge_state *bridge_state,
+                              struct drm_crtc_state *crtc_state,
+                              struct drm_connector_state *conn_state)
+{
+       struct tfp410 *dvi = drm_bridge_to_tfp410(bridge);
+
+       /*
+        * There might be flags negotiation supported in future.
+        * Set the bus flags in atomic_check statically for now.
+        */
+       bridge_state->input_bus_cfg.flags = dvi->timings.input_bus_flags;
+
+       return 0;
+}
+
 static const struct drm_bridge_funcs tfp410_bridge_funcs = {
        .attach         = tfp410_attach,
        .detach         = tfp410_detach,
@@ -238,6 +254,7 @@ static const struct drm_bridge_funcs tfp410_bridge_funcs = {
        .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
        .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
        .atomic_get_input_bus_fmts = tfp410_get_input_bus_fmts,
+       .atomic_check = tfp410_atomic_check,
 };
 
 static const struct drm_bridge_timings tfp410_default_timings = {