]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
video: fbdev: au1200fb: delete double assignment
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sat, 23 Aug 2014 18:33:28 +0000 (20:33 +0200)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Tue, 26 Aug 2014 12:53:35 +0000 (15:53 +0300)
Delete successive assignments to the same location.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression i;
@@

*i = ...;
 i = ...;
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/fbdev/au1200fb.c

index 40494dbdf519da721649ff66e368ad6e2a169125..18600d4e1b3fdd314a24289449dabef50c1ee917 100644 (file)
@@ -1254,7 +1254,6 @@ static void set_global(u_int cmd, struct au1200_lcd_global_regs_t *pdata)
                        pdata->brightness = 30;
                }
                divider = (lcd->pwmdiv & 0x3FFFF) + 1;
-               hi1 = (lcd->pwmhi >> 16) + 1;
                hi1 = (((pdata->brightness & 0xFF)+1) * divider >> 8);
                lcd->pwmhi &= 0xFFFF;
                lcd->pwmhi |= (hi1 << 16);