]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
gfs2: Replace deprecated kmap_atomic with kmap_local_page
authorDeepak R Varma <drv@mailo.com>
Mon, 26 Jun 2023 06:51:09 +0000 (12:21 +0530)
committerAndreas Gruenbacher <agruenba@redhat.com>
Mon, 3 Jul 2023 20:30:47 +0000 (22:30 +0200)
kmap_atomic() is deprecated in favor of kmap_local_{folio,page}().

Therefore, replace kmap_atomic() with kmap_local_page() in
gfs2_internal_read() and stuffed_readpage().

kmap_atomic() disables page-faults and preemption (the latter only for
!PREEMPT_RT kernels), However, the code within the mapping/un-mapping in
gfs2_internal_read() and stuffed_readpage() does not depend on the
above-mentioned side effects.

Therefore, a mere replacement of the old API with the new one is all that
is required (i.e., there is no need to explicitly add any calls to
pagefault_disable() and/or preempt_disable()).

Signed-off-by: Deepak R Varma <drv@mailo.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
fs/gfs2/aops.c

index dacc21b1ae001a4785e06c2ca1d5bc62a3d2d0d7..c45bac9b5408ab04c395963ed92e7989296ef236 100644 (file)
@@ -431,10 +431,10 @@ static int stuffed_readpage(struct gfs2_inode *ip, struct page *page)
        if (error)
                return error;
 
-       kaddr = kmap_atomic(page);
+       kaddr = kmap_local_page(page);
        memcpy(kaddr, dibh->b_data + sizeof(struct gfs2_dinode), dsize);
        memset(kaddr + dsize, 0, PAGE_SIZE - dsize);
-       kunmap_atomic(kaddr);
+       kunmap_local(kaddr);
        flush_dcache_page(page);
        brelse(dibh);
        SetPageUptodate(page);
@@ -497,12 +497,12 @@ int gfs2_internal_read(struct gfs2_inode *ip, char *buf, loff_t *pos,
                                continue;
                        return PTR_ERR(page);
                }
-               p = kmap_atomic(page);
+               p = kmap_local_page(page);
                amt = size - copied;
                if (offset + size > PAGE_SIZE)
                        amt = PAGE_SIZE - offset;
                memcpy(buf + copied, p + offset, amt);
-               kunmap_atomic(p);
+               kunmap_local(p);
                put_page(page);
                copied += amt;
                index++;