ofp-parse: Correctly report error parsing selection method parameter.

Found by LLVM scan-build.

Reported-by: Kevin Lo <kevlo@FreeBSD.org>
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Simon Horman <simon.horman@netronome.com>
Acked-by: Kevin Lo <kevlo@FreeBSD.org>

diff --git a/lib/ofp-parse.c b/lib/ofp-parse.c
index ffb17fa82d84916e53ff976b2e29a9baefa008c1..856044dbb3ddfa82eec9319541e7b81f95f3ec00 100644 (file)
--- a/lib/ofp-parse.c
+++ b/lib/ofp-parse.c
@@ -1409,6 +1409,9 @@ parse_ofp_group_mod_str__(struct ofputil_group_mod *gm, uint16_t command,
                 goto out;
             }
             error = str_to_u64(value, &gm->props.selection_method_param);
+            if (error) {
+                goto out;
+            }
             *usable_protocols &= OFPUTIL_P_OF15_UP;
         } else if (!strcmp(name, "fields")) {
             if (!(fields & F_GROUP_TYPE)) {