]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
staging: et131x: Remove unnecessary i2c_wack variable
authorMark Einon <mark.einon@gmail.com>
Thu, 21 Aug 2014 15:02:32 +0000 (16:02 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 30 Aug 2014 20:34:08 +0000 (13:34 -0700)
i2c_wack is only used to implement a while(1) loop, so let's remove it.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/et131x/et131x.c

index bd63dc4e78922767b852281f08e5858bd516c44a..45fc364da4f910d5336b0802669b88578716c1b8 100644 (file)
@@ -573,7 +573,6 @@ static int eeprom_write(struct et131x_adapter *adapter, u32 addr, u8 data)
        int index = 0;
        int retries;
        int err = 0;
-       int i2c_wack = 0;
        int writeok = 0;
        u32 status;
        u32 val = 0;
@@ -599,8 +598,6 @@ static int eeprom_write(struct et131x_adapter *adapter, u32 addr, u8 data)
                        LBCIF_CONTROL_LBCIF_ENABLE | LBCIF_CONTROL_I2C_WRITE))
                return -EIO;
 
-       i2c_wack = 1;
-
        /* Prepare EEPROM address for Step 3 */
 
        for (retries = 0; retries < MAX_NUM_WRITE_RETRIES; retries++) {
@@ -656,7 +653,7 @@ static int eeprom_write(struct et131x_adapter *adapter, u32 addr, u8 data)
         */
        udelay(10);
 
-       while (i2c_wack) {
+       while (1) {
                if (pci_write_config_byte(pdev, LBCIF_CONTROL_REGISTER,
                        LBCIF_CONTROL_LBCIF_ENABLE))
                        writeok = 0;