]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
net: ipv4: Remove unneed BUG() function
authorZheng Yongjun <zhengyongjun3@huawei.com>
Tue, 8 Jun 2021 01:53:15 +0000 (09:53 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 8 Jun 2021 18:36:48 +0000 (11:36 -0700)
When 'nla_parse_nested_deprecated' failed, it's no need to
BUG() here, return -EINVAL is ok.

Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/devinet.c
net/ipv6/addrconf.c

index 2e35f68da40a7f8f9698b724efaa6698de3d3733..1c6429c353a962bdc3a3385e5ab7fc2225598625 100644 (file)
@@ -1989,7 +1989,7 @@ static int inet_set_link_af(struct net_device *dev, const struct nlattr *nla,
                return -EAFNOSUPPORT;
 
        if (nla_parse_nested_deprecated(tb, IFLA_INET_MAX, nla, NULL, NULL) < 0)
-               BUG();
+               return -EINVAL;
 
        if (tb[IFLA_INET_CONF]) {
                nla_for_each_nested(a, tb[IFLA_INET_CONF], rem)
index b0ef65eb9bd21dee6ca552114ece637bbb8c1352..701eb82acd1c567ab9bb1914171a52aff4c257d2 100644 (file)
@@ -5827,7 +5827,7 @@ static int inet6_set_link_af(struct net_device *dev, const struct nlattr *nla,
                return -EAFNOSUPPORT;
 
        if (nla_parse_nested_deprecated(tb, IFLA_INET6_MAX, nla, NULL, NULL) < 0)
-               BUG();
+               return -EINVAL;
 
        if (tb[IFLA_INET6_TOKEN]) {
                err = inet6_set_iftoken(idev, nla_data(tb[IFLA_INET6_TOKEN]),