]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
mwifiex: Call pci_release_region after calling pci_disable_device
authorYogesh Ashok Powar <yogeshp@marvell.com>
Tue, 23 Apr 2013 23:49:48 +0000 (16:49 -0700)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 26 Apr 2013 12:42:21 +0000 (08:42 -0400)
"drivers should call pci_release_region() AFTER
calling pci_disable_device()"

Please refer section 3.2 Request MMIO/IOP resources
in Documentation/PCI/pci.txt

Cc: <stable@vger.kernel.org> # 3.2+
Signed-off-by: Avinash Patil <patila@marvell.com>
Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Yogesh Ashok Powar <yogeshp@marvell.com>
Signed-off-by: Bing Zhao <bzhao@marvell.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/mwifiex/pcie.c

index fec2a617bf984440111f058d43e843c6def73fba..b924e1d9cf9ce78a29a43492d99678e3c00f0a94 100644 (file)
@@ -2294,9 +2294,9 @@ static void mwifiex_pcie_cleanup(struct mwifiex_adapter *adapter)
        if (pdev) {
                pci_iounmap(pdev, card->pci_mmap);
                pci_iounmap(pdev, card->pci_mmap1);
+               pci_disable_device(pdev);
                pci_release_region(pdev, 2);
                pci_release_region(pdev, 0);
-               pci_disable_device(pdev);
                pci_set_drvdata(pdev, NULL);
        }
 }