]> git.proxmox.com Git - pve-manager.git/commitdiff
correct the upgradecmd for xtermjs
authorDominik Csapak <d.csapak@proxmox.com>
Wed, 17 Jan 2018 09:33:19 +0000 (10:33 +0100)
committerWolfgang Bumiller <w.bumiller@proxmox.com>
Thu, 18 Jan 2018 09:05:54 +0000 (10:05 +0100)
use the pveupgrade command directly without bash inbetween,
the incorrect quoting led to '--shell' not being passed to
pveupgrade and closing the connection

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Tested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
PVE/API2/Nodes.pm

index f11fd169eddca8e4a4a6b63bb9261c7f4bd8dc64..ed6779e60365f205bd35f9bc4ab4aed5e4eeb5f7 100644 (file)
@@ -822,8 +822,7 @@ __PACKAGE__->register_method ({
 
        if ($user eq 'root@pam') {
            if ($param->{upgrade}) {
-               my $upgradecmd = "pveupgrade --shell";
-               $concmd = [ '/bin/bash', '-c', $upgradecmd ];
+               $concmd = [ '/usr/bin/pveupgrade', '--shell' ];
            } else {
                $concmd = [ '/bin/login', '-f', 'root' ];
            }