]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
remoteproc: qcom: Fix missing of_node_put in adsp_alloc_memory_region
authorMiaoqian Lin <linmq006@gmail.com>
Tue, 8 Mar 2022 03:12:19 +0000 (03:12 +0000)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 20 May 2022 13:19:10 +0000 (15:19 +0200)
BugLink: https://bugs.launchpad.net/bugs/1971497
[ Upstream commit 505b5b1616e200042999de715dbe7c1e2735cd65 ]

The device_node pointer is returned by of_parse_phandle()  with refcount
incremented. We should use of_node_put() on it when done.

Fixes: dc160e449122 ("remoteproc: qcom: Introduce Non-PAS ADSP PIL driver")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20220308031219.4718-1-linmq006@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/remoteproc/qcom_q6v5_adsp.c

index 24e8b7e271773072c380d3d1e31f9d43e4e8854a..6b131a490ebf8e881efcbbad004e7bcc305394a9 100644 (file)
@@ -389,6 +389,7 @@ static int adsp_alloc_memory_region(struct qcom_adsp *adsp)
        }
 
        ret = of_address_to_resource(node, 0, &r);
+       of_node_put(node);
        if (ret)
                return ret;