UBUNTU: SAUCE: base/dd: limit release function changes to vfio driver only

It seems that we can trigger the new race detection after remove()
with some drivers which clear the driver as they unreference
the module.  This leads us to fail to clear down those devices which
triggers suspend/resume issues.

Limit the core changes to only apply to the vfio driver while we
work with upstream on a more generic fix.

Fixes: 876dcb5f4576 ("UBUNTU: SAUCE: vfio -- release device lock before userspace requests")
BugLink: http://bugs.launchpad.net/bugs/1803942
Signed-off-by: Andy Whitcroft <apw@canonical.com>
Acked-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index 37c01054521b24336e09238d12dd81abcf679eb1..045d4e4485b8b4e47d4ce790b824b1daaab18dbc 100644 (file)
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -820,6 +820,9 @@ int driver_attach(struct device_driver *drv)
 }
 EXPORT_SYMBOL_GPL(driver_attach);
 
+void *vfio_pci_driver_ptr = (void *)0xdeadfeed;
+EXPORT_SYMBOL(vfio_pci_driver_ptr);
+
 /*
  * __device_release_driver() must be called with @dev lock held.
  * When called for a USB interface, @dev->parent lock must be held as well.
@@ -872,8 +875,13 @@ static void __device_release_driver(struct device *dev, struct device *parent)
                 * A concurrent invocation of the same function might
                 * have released the driver successfully while this one
                 * was waiting, so check for that.
+                * LP: #1792099
+                *
+                * Limit this to the vfio_pci_driver as some drivers NULL
+                * out this pointer in their remove() function.
+                * LP: #1803942
                 */
-               if (dev->driver != drv)
+               if (drv == vfio_pci_driver_ptr && dev->driver != drv)
                        return;
 
                device_links_driver_cleanup(dev);

diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c
index f041b1a6cf665e6410917d3608de5fe0ac557476..6e70281715c4c4e2a8cefba27eb0033984ef6f13 100644 (file)
--- a/drivers/vfio/pci/vfio_pci.c
+++ b/drivers/vfio/pci/vfio_pci.c
@@ -1310,6 +1310,7 @@ static struct pci_driver vfio_pci_driver = {
        .remove         = vfio_pci_remove,
        .err_handler    = &vfio_err_handlers,
 };
+extern void *vfio_pci_driver_ptr;
 
 struct vfio_devices {
        struct vfio_device **devices;
@@ -1404,6 +1405,8 @@ put_devs:
 
 static void __exit vfio_pci_cleanup(void)
 {
+       vfio_pci_driver_ptr = (void *)0xdeadfeed;
+
        pci_unregister_driver(&vfio_pci_driver);
        vfio_pci_uninit_perm_bits();
 }
@@ -1465,6 +1468,9 @@ static int __init vfio_pci_init(void)
 
        vfio_pci_fill_ids();
 
+       /* Advertise my address. */
+       vfio_pci_driver_ptr = &vfio_pci_driver;
+
        return 0;
 
 out_driver: