]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
perf script: Use pr_debug where appropriate
authorArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 26 Oct 2017 12:55:22 +0000 (09:55 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 27 Oct 2017 12:10:09 +0000 (09:10 -0300)
We have facilities for reporting unexpected, unlikely errors, use them.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Cc: yuzhoujian <yuzhoujian@didichuxing.com>
Link: http://lkml.kernel.org/n/tip-c7j22xfjf1j773g7ufp607q0@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-script.c

index db4ff1510dc5a822d607b5650fb8e6251324c500..af0267072d433914a216fc6ca92934ea6b649f6b 100644 (file)
@@ -769,27 +769,26 @@ static int grab_bb(u8 *buffer, u64 start, u64 end,
         * but the exit is not. Let the caller patch it up.
         */
        if (kernel != machine__kernel_ip(machine, end)) {
-               printf("\tblock %" PRIx64 "-%" PRIx64 " transfers between kernel and user\n",
-                               start, end);
+               pr_debug("\tblock %" PRIx64 "-%" PRIx64 " transfers between kernel and user\n", start, end);
                return -ENXIO;
        }
 
        memset(&al, 0, sizeof(al));
        if (end - start > MAXBB - MAXINSN) {
                if (last)
-                       printf("\tbrstack does not reach to final jump (%" PRIx64 "-%" PRIx64 ")\n", start, end);
+                       pr_debug("\tbrstack does not reach to final jump (%" PRIx64 "-%" PRIx64 ")\n", start, end);
                else
-                       printf("\tblock %" PRIx64 "-%" PRIx64 " (%" PRIu64 ") too long to dump\n", start, end, end - start);
+                       pr_debug("\tblock %" PRIx64 "-%" PRIx64 " (%" PRIu64 ") too long to dump\n", start, end, end - start);
                return 0;
        }
 
        thread__find_addr_map(thread, *cpumode, MAP__FUNCTION, start, &al);
        if (!al.map || !al.map->dso) {
-               printf("\tcannot resolve %" PRIx64 "-%" PRIx64 "\n", start, end);
+               pr_debug("\tcannot resolve %" PRIx64 "-%" PRIx64 "\n", start, end);
                return 0;
        }
        if (al.map->dso->data.status == DSO_DATA_STATUS_ERROR) {
-               printf("\tcannot resolve %" PRIx64 "-%" PRIx64 "\n", start, end);
+               pr_debug("\tcannot resolve %" PRIx64 "-%" PRIx64 "\n", start, end);
                return 0;
        }
 
@@ -802,7 +801,7 @@ static int grab_bb(u8 *buffer, u64 start, u64 end,
 
        *is64bit = al.map->dso->is_64_bit;
        if (len <= 0)
-               printf("\tcannot fetch code for block at %" PRIx64 "-%" PRIx64 "\n",
+               pr_debug("\tcannot fetch code for block at %" PRIx64 "-%" PRIx64 "\n",
                        start, end);
        return len;
 }