]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
net: make xps_needed and xps_rxqs_needed static
authorVladimir Oltean <vladimir.oltean@nxp.com>
Mon, 22 Mar 2021 11:30:19 +0000 (13:30 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 22 Mar 2021 20:13:55 +0000 (13:13 -0700)
Since their introduction in commit 04157469b7b8 ("net: Use static_key
for XPS maps"), xps_needed and xps_rxqs_needed were never used outside
net/core/dev.c, so I don't really understand why they were exported as
symbols in the first place.

This is needed in order to silence a "make W=1" warning about these
static keys not being declared as static variables, but not having a
previous declaration in a header file nonetheless.

Cc: Amritha Nambiar <amritha.nambiar@intel.com>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/dev.c

index be941ed754ac71d0839604bcfdd8ab67c339d27f..ffab3928eeeb662b34c1963b3d9326f524c69430 100644 (file)
@@ -2451,10 +2451,8 @@ int netdev_txq_to_tc(struct net_device *dev, unsigned int txq)
 EXPORT_SYMBOL(netdev_txq_to_tc);
 
 #ifdef CONFIG_XPS
-struct static_key xps_needed __read_mostly;
-EXPORT_SYMBOL(xps_needed);
-struct static_key xps_rxqs_needed __read_mostly;
-EXPORT_SYMBOL(xps_rxqs_needed);
+static struct static_key xps_needed __read_mostly;
+static struct static_key xps_rxqs_needed __read_mostly;
 static DEFINE_MUTEX(xps_map_mutex);
 #define xmap_dereference(P)            \
        rcu_dereference_protected((P), lockdep_is_held(&xps_map_mutex))