]> git.proxmox.com Git - mirror_kronosnet.git/commitdiff
[tests] fix api_knet_log_set_loglevel incorrect exit sequence
authorFabio M. Di Nitto <fdinitto@redhat.com>
Sun, 26 Jun 2016 04:18:32 +0000 (06:18 +0200)
committerFabio M. Di Nitto <fdinitto@redhat.com>
Sun, 26 Jun 2016 04:18:32 +0000 (06:18 +0200)
Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
libknet/tests/api_knet_log_set_loglevel.c

index 0493eb3924dfac644d1fa3c745eb6134bc0a7729..888ed698797f6c442e0bce229b76c9d7b278465d 100644 (file)
@@ -58,11 +58,11 @@ static void test(void)
 
        printf("Test knet_log_set_loglevel incorrect log level\n");
 
-       if ((!knet_log_set_loglevel(knet_h, KNET_SUB_LAST , KNET_LOG_DEBUG + 1)) || (errno != EINVAL)) {
+       if ((!knet_log_set_loglevel(knet_h, KNET_SUB_LAST, KNET_LOG_DEBUG + 1)) || (errno != EINVAL)) {
                printf("knet_log_set_loglevel accepted invalid log level or returned incorrect error: %s\n", strerror(errno));
+               knet_handle_free(knet_h);
                flush_logs(logfds[0], stdout);
                close_logpipes(logfds);
-               knet_handle_free(knet_h);
                exit(FAIL);
        }
 
@@ -72,25 +72,25 @@ static void test(void)
 
        if (knet_h->log_levels[KNET_SUB_LAST] != KNET_LOG_INFO) {
                printf("knet_handle_new did not init log_levels correctly?\n");
+               knet_handle_free(knet_h);
                flush_logs(logfds[0], stdout);
                close_logpipes(logfds);
-               knet_handle_free(knet_h);
                exit(FAIL);
        }
 
-       if (knet_log_set_loglevel(knet_h, KNET_SUB_LAST , KNET_LOG_DEBUG) < 0) {
+       if (knet_log_set_loglevel(knet_h, KNET_SUB_LAST, KNET_LOG_DEBUG) < 0) {
                printf("knet_log_set_loglevel failed: %s\n", strerror(errno));
+               knet_handle_free(knet_h);
                flush_logs(logfds[0], stdout);
                close_logpipes(logfds);
-               knet_handle_free(knet_h);
                exit(FAIL);
        }
 
        if (knet_h->log_levels[KNET_SUB_LAST] != KNET_LOG_DEBUG) {
                printf("knet_log_set_loglevel did not set log level correctly\n");
+               knet_handle_free(knet_h);
                flush_logs(logfds[0], stdout);
                close_logpipes(logfds);
-               knet_handle_free(knet_h);
                exit(FAIL);
        }