]> git.proxmox.com Git - qemu.git/commitdiff
vnc: Fix fatal crash with vnc reverse mode
authorStefan Weil <weil@mail.berlios.de>
Wed, 16 Feb 2011 19:48:00 +0000 (20:48 +0100)
committerAnthony Liguori <aliguori@us.ibm.com>
Wed, 23 Feb 2011 22:28:29 +0000 (16:28 -0600)
Reverse mode is unusable:

qemu -vnc localhost:5500,reverse

crashes in vnc_refresh_server_surface because some pointers are NULL.

Fix this by calling vnc_dpy_resize (which initializes these pointers)
before calling vnc_refresh.

Cc: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
ui/vnc.c

index 626b4300950a3fc9ba1c683856f7fdb8a0f271f3..610f88485e99ef85c206acde6cee164092a66c30 100644 (file)
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -2480,6 +2480,7 @@ static void vnc_init_timer(VncDisplay *vd)
     vd->timer_interval = VNC_REFRESH_INTERVAL_BASE;
     if (vd->timer == NULL && !QTAILQ_EMPTY(&vd->clients)) {
         vd->timer = qemu_new_timer(rt_clock, vnc_refresh, vd);
+        vnc_dpy_resize(vd->ds);
         vnc_refresh(vd);
     }
 }