]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commitdiff
ARM: dts: exynos: Fix mismatched values of SD drive strengh configuration on exynos4415
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>
Sun, 4 Sep 2016 11:04:16 +0000 (13:04 +0200)
committerKrzysztof Kozlowski <k.kozlowski@samsung.com>
Fri, 16 Sep 2016 11:32:13 +0000 (13:32 +0200)
The pinctrl drive strength register on exynos4415 is 2-bit wide for each
pin.  The pins for SD2 were configured with value of 4.  The driver does
not validate the value so this overflow effectively set a bit 1 in
adjacent pins thus configuring them to drive strength 2x.

The author's intention was probably to set drive strength of 4x.
All other SD pins are configured with drive strength of 4x.  Fix these
with same pattern.

Fixes: 9246e7ff24c5 ("ARM: dts: Add dts files for exynos4415 SoC")
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
arch/arm/boot/dts/exynos4415-pinctrl.dtsi

index f54aee53b6ec58db80c9699fa4fa557847e96bf8..76cfd872ead3923b578038d8c7611461adbf0143 100644 (file)
                samsung,pins = "gpk2-0";
                samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
                samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
-               samsung,pin-drv = <4>;
+               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
        };
 
        sd2_cmd: sd2-cmd {
                samsung,pins = "gpk2-1";
                samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
                samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
-               samsung,pin-drv = <4>;
+               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
        };
 
        sd2_cd: sd2-cd {
                samsung,pins = "gpk2-3";
                samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
                samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
-               samsung,pin-drv = <4>;
+               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
        };
 
        sd2_bus4: sd2-bus-width4 {
                samsung,pins = "gpk2-4", "gpk2-5", "gpk2-6";
                samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
                samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
-               samsung,pin-drv = <4>;
+               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
        };
 
        cam_port_b_io: cam-port-b-io {