]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
ARM: locomo: fix locomolcd_power declaration
authorArnd Bergmann <arnd@arndb.de>
Wed, 27 Sep 2023 19:38:10 +0000 (21:38 +0200)
committerArnd Bergmann <arnd@arndb.de>
Thu, 28 Sep 2023 07:15:51 +0000 (09:15 +0200)
The locomolcd driver has one remaining missing-prototype warning:

drivers/video/backlight/locomolcd.c:83:6: error: no previous prototype for 'locomolcd_power' [-Werror=missing-prototypes]

There is in fact an unused prototype with a similar name in a global
header, so move the actual one there and remove the old one.

Link: https://lore.kernel.org/r/20230927194844.680771-1-arnd@kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
arch/arm/include/asm/hardware/locomo.h
arch/arm/mach-sa1100/include/mach/collie.h

index 246a3de25931db6d65259933fee7d50169a81f2f..aaaedafef7cce6ce0caefc726cf229aa510e15c2 100644 (file)
@@ -195,7 +195,7 @@ struct locomo_driver {
 
 #define LOCOMO_DRIVER_NAME(_ldev) ((_ldev)->dev.driver->name)
 
-void locomo_lcd_power(struct locomo_dev *, int, unsigned int);
+extern void locomolcd_power(int on);
 
 int locomo_driver_register(struct locomo_driver *);
 void locomo_driver_unregister(struct locomo_driver *);
index b7bc23ffd3c696284d0d75423e747d7e3879f771..c95273c9567bb944c153c39417dbcf624c97fa3b 100644 (file)
@@ -16,8 +16,6 @@
 
 #include "hardware.h" /* Gives GPIO_MAX */
 
-extern void locomolcd_power(int on);
-
 #define COLLIE_SCOOP_GPIO_BASE (GPIO_MAX + 1)
 #define COLLIE_GPIO_CHARGE_ON  (COLLIE_SCOOP_GPIO_BASE + 0)
 #define COLLIE_SCP_DIAG_BOOT1  SCOOP_GPCR_PA12