]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
nvme: remove the GENHD_FL_UP check in nvme_ns_remove
authorChristoph Hellwig <hch@lst.de>
Mon, 9 Aug 2021 06:40:23 +0000 (08:40 +0200)
committerJens Axboe <axboe@kernel.dk>
Thu, 12 Aug 2021 16:29:36 +0000 (10:29 -0600)
Early probe failure never reaches nvme_ns_remove, so GENHD_FL_UP must
be set at this point.  Remove the check.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20210809064028.1198327-4-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/nvme/host/core.c

index f6c0a59c4b532a9ef5eade22375f06fe8776f8c9..dbe7144f0026cf9e73709555863fc781e4f27710 100644 (file)
@@ -3826,14 +3826,12 @@ static void nvme_ns_remove(struct nvme_ns *ns)
        nvme_mpath_clear_current_path(ns);
        synchronize_srcu(&ns->head->srcu); /* wait for concurrent submissions */
 
-       if (ns->disk->flags & GENHD_FL_UP) {
-               if (!nvme_ns_head_multipath(ns->head))
-                       nvme_cdev_del(&ns->cdev, &ns->cdev_device);
-               del_gendisk(ns->disk);
-               blk_cleanup_queue(ns->queue);
-               if (blk_get_integrity(ns->disk))
-                       blk_integrity_unregister(ns->disk);
-       }
+       if (!nvme_ns_head_multipath(ns->head))
+               nvme_cdev_del(&ns->cdev, &ns->cdev_device);
+       del_gendisk(ns->disk);
+       blk_cleanup_queue(ns->queue);
+       if (blk_get_integrity(ns->disk))
+               blk_integrity_unregister(ns->disk);
 
        down_write(&ns->ctrl->namespaces_rwsem);
        list_del_init(&ns->list);