]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
target: Drop bogus ERR_PTR usage in target_fabric_configfs_init
authorDan Carpenter <error27@gmail.com>
Mon, 13 Jun 2011 20:10:49 +0000 (23:10 +0300)
committerNicholas Bellinger <nab@linux-iscsi.org>
Fri, 24 Jun 2011 00:03:51 +0000 (00:03 +0000)
In the original code, there were several places inside the
target_fabric_configfs_init() function that returned NULL on error
and one place the returned an ERR_PTR.  There are two places that
call this function and they only check for NULL returns; they don't
check for ERR_PTRs.  So I've changed the ERR_PTR so now the function
only returns NULL on error.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_configfs.c

index ee6fad979b50c82fa9ff2fc9f8121a62f32d7bb5..b17abd13c8e316e2a362c25061ba413ede414c21 100644 (file)
@@ -312,7 +312,7 @@ struct target_fabric_configfs *target_fabric_configfs_init(
 
        tf = kzalloc(sizeof(struct target_fabric_configfs), GFP_KERNEL);
        if (!(tf))
-               return ERR_PTR(-ENOMEM);
+               return NULL;
 
        INIT_LIST_HEAD(&tf->tf_list);
        atomic_set(&tf->tf_access_cnt, 0);