]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
xtensa: fix access check in csum_and_copy_from_user
authorMax Filippov <jcmvbkbc@gmail.com>
Tue, 21 Jul 2020 22:00:35 +0000 (15:00 -0700)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 21 Jul 2020 23:08:25 +0000 (19:08 -0400)
Commit d341659f470b ("xtensa: switch to providing
csum_and_copy_from_user()") introduced access check, but incorrectly
tested dst instead of src.
Fix access_ok argument in csum_and_copy_from_user.

Cc: Al Viro <viro@zeniv.linux.org.uk>
Fixes: d341659f470b ("xtensa: switch to providing csum_and_copy_from_user()")
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
arch/xtensa/include/asm/checksum.h

index d8292cc9ebdf88c3389d0ed9a50a2eea1be25790..243a5fe79d3cdfccc0d535e92d54a40ffaf217c1 100644 (file)
@@ -57,7 +57,7 @@ static inline
 __wsum csum_and_copy_from_user(const void __user *src, void *dst,
                                   int len, __wsum sum, int *err_ptr)
 {
-       if (access_ok(dst, len))
+       if (access_ok(src, len))
                return csum_partial_copy_generic((__force const void *)src, dst,
                                        len, sum, err_ptr, NULL);
        if (len)