bgpd: fix memory leak when deleting a community

* bgp_routemap.c: (route_set_community_delete) When deleting a
  community in a route-map the old community was being orphaned.  Like
  the description of the same code in route_set_community, this is a
  hack, not a true fix.

diff --git a/bgpd/bgp_routemap.c b/bgpd/bgp_routemap.c
index 81ff48dbd6cb5278568b371a95c6292c4926d4f9..255b25aedfbc827602e5b6429da9a0d2fee5a6f2 100644 (file)
--- a/bgpd/bgp_routemap.c
+++ b/bgpd/bgp_routemap.c
@@ -1393,6 +1393,13 @@ route_set_community_delete (void *rule, struct prefix *prefix,
          new = community_uniq_sort (merge);
          community_free (merge);
 
+         /* HACK: if the old community is not intern'd,
+          * we should free it here, or all reference to it may be lost.
+          * Really need to cleanup attribute caching sometime.
+          */
+         if (old->refcnt == 0)
+           community_free (old);
+
          if (new->size == 0)
            {
              binfo->attr->community = NULL;