]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
bnxt_en: Properly remove port parameter support
authorLeon Romanovsky <leonro@nvidia.com>
Thu, 23 Sep 2021 18:12:49 +0000 (21:12 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 24 Sep 2021 13:12:56 +0000 (14:12 +0100)
This driver doesn't have any port parameters and registers
devlink port parameters with empty table. Remove the useless
calls to devlink_port_params_register and _unregister.

Fixes: da203dfa89ce ("Revert "devlink: Add a generic wake_on_lan port parameter"")
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Reviewed-by: Edwin Peer <edwin.peer@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c

index dc0851f709f523da566dcfcbe90b5698a5eba229..ed95e28d60efd3688a97e22cdee79b101f7d3040 100644 (file)
@@ -736,9 +736,6 @@ static const struct devlink_param bnxt_dl_params[] = {
                             NULL),
 };
 
-static const struct devlink_param bnxt_dl_port_params[] = {
-};
-
 static int bnxt_dl_params_register(struct bnxt *bp)
 {
        int rc;
@@ -753,14 +750,6 @@ static int bnxt_dl_params_register(struct bnxt *bp)
                            rc);
                return rc;
        }
-       rc = devlink_port_params_register(&bp->dl_port, bnxt_dl_port_params,
-                                         ARRAY_SIZE(bnxt_dl_port_params));
-       if (rc) {
-               netdev_err(bp->dev, "devlink_port_params_register failed\n");
-               devlink_params_unregister(bp->dl, bnxt_dl_params,
-                                         ARRAY_SIZE(bnxt_dl_params));
-               return rc;
-       }
        devlink_params_publish(bp->dl);
 
        return 0;
@@ -773,8 +762,6 @@ static void bnxt_dl_params_unregister(struct bnxt *bp)
 
        devlink_params_unregister(bp->dl, bnxt_dl_params,
                                  ARRAY_SIZE(bnxt_dl_params));
-       devlink_port_params_unregister(&bp->dl_port, bnxt_dl_port_params,
-                                      ARRAY_SIZE(bnxt_dl_port_params));
 }
 
 int bnxt_dl_register(struct bnxt *bp)