]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
media: i2c: adv748x: Export I2C device table entries as module aliases
authorJavier Martinez Canillas <javierm@redhat.com>
Wed, 9 Aug 2017 09:37:30 +0000 (05:37 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Sun, 27 Aug 2017 22:12:14 +0000 (18:12 -0400)
The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
device was registered via OF, and the driver is only exporting the OF ID
table entries as module aliases.

So if the driver is built as module, autoload won't work since udev/kmod
won't be able to match the registered OF device with its driver module.

Before this patch:

$ modinfo drivers/media/i2c/adv748x/adv748x.ko | grep alias
alias:          of:N*T*Cadi,adv7482C*
alias:          of:N*T*Cadi,adv7482
alias:          of:N*T*Cadi,adv7481C*
alias:          of:N*T*Cadi,adv7481

After this patch:

modinfo drivers/media/i2c/adv748x/adv748x.ko | grep alias
alias:          of:N*T*Cadi,adv7482C*
alias:          of:N*T*Cadi,adv7482
alias:          of:N*T*Cadi,adv7481C*
alias:          of:N*T*Cadi,adv7481
alias:          i2c:adv7482
alias:          i2c:adv7481

Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/i2c/adv748x/adv748x-core.c

index aeb6ae80cb184eb4c49f55e83e90efb128ee6976..5ee14f2c27478e3abaa01c39264f7a161f69a895 100644 (file)
@@ -807,6 +807,7 @@ static const struct i2c_device_id adv748x_id[] = {
        { "adv7482", 0 },
        { },
 };
+MODULE_DEVICE_TABLE(i2c, adv748x_id);
 
 static const struct of_device_id adv748x_of_table[] = {
        { .compatible = "adi,adv7481", },