]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
net: phy: bcm7xxx: Add missing 16nm EPHY statistics
authorFlorian Fainelli <florian.fainelli@broadcom.com>
Tue, 17 Oct 2023 20:51:19 +0000 (13:51 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 19 Oct 2023 01:13:13 +0000 (18:13 -0700)
The .probe() function would allocate the necessary space and ensure that
the library call sizes the number of statistics but the callbacks
necessary to fetch the name and values were not wired up.

Reported-by: Justin Chen <justin.chen@broadcom.com>
Fixes: f68d08c437f9 ("net: phy: bcm7xxx: Add EPHY entry for 72165")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20231017205119.416392-1-florian.fainelli@broadcom.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/bcm7xxx.c

index 8478b081c058da1022454b7d8f54f7b87147b479..97638ba7ae851d693710e2b508b658bb81ad2c28 100644 (file)
@@ -894,6 +894,9 @@ static int bcm7xxx_28nm_probe(struct phy_device *phydev)
        .name           = _name,                                        \
        /* PHY_BASIC_FEATURES */                                        \
        .flags          = PHY_IS_INTERNAL,                              \
+       .get_sset_count = bcm_phy_get_sset_count,                       \
+       .get_strings    = bcm_phy_get_strings,                          \
+       .get_stats      = bcm7xxx_28nm_get_phy_stats,                   \
        .probe          = bcm7xxx_28nm_probe,                           \
        .config_init    = bcm7xxx_16nm_ephy_config_init,                \
        .config_aneg    = genphy_config_aneg,                           \