]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commitdiff
OMAPDSS: TFP410: fix input sync signals
authorTomi Valkeinen <tomi.valkeinen@ti.com>
Thu, 25 Sep 2014 13:00:44 +0000 (16:00 +0300)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Thu, 26 Feb 2015 10:15:11 +0000 (12:15 +0200)
TFP410 requires that DE is active high and the data and syncs are driven
on rising pixel clock edge. However, at the moment the driver doesn't
request such syncs, and the end result is that the sync settings depend
on default values, which are not right in all cases.

Set the sync values explicitly.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/fbdev/omap2/displays-new/encoder-tfp410.c

index 92919a74e7156097a5e7ef765e77fdeb2e1674b4..d9048b3df495c0b2ec11d2ddef1a702ef0df05c5 100644 (file)
@@ -114,12 +114,21 @@ static void tfp410_disable(struct omap_dss_device *dssdev)
        dssdev->state = OMAP_DSS_DISPLAY_DISABLED;
 }
 
+static void tfp410_fix_timings(struct omap_video_timings *timings)
+{
+       timings->data_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE;
+       timings->sync_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE;
+       timings->de_level = OMAPDSS_SIG_ACTIVE_HIGH;
+}
+
 static void tfp410_set_timings(struct omap_dss_device *dssdev,
                struct omap_video_timings *timings)
 {
        struct panel_drv_data *ddata = to_panel_data(dssdev);
        struct omap_dss_device *in = ddata->in;
 
+       tfp410_fix_timings(timings);
+
        ddata->timings = *timings;
        dssdev->panel.timings = *timings;
 
@@ -140,6 +149,8 @@ static int tfp410_check_timings(struct omap_dss_device *dssdev,
        struct panel_drv_data *ddata = to_panel_data(dssdev);
        struct omap_dss_device *in = ddata->in;
 
+       tfp410_fix_timings(timings);
+
        return in->ops.dpi->check_timings(in, timings);
 }