]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
drm/msm/gpu: Move fw loading out of hw_init() path
authorRob Clark <robdclark@chromium.org>
Mon, 20 Mar 2023 14:43:34 +0000 (07:43 -0700)
committerRob Clark <robdclark@chromium.org>
Sat, 25 Mar 2023 23:31:44 +0000 (16:31 -0700)
It is already a no-op, since we've already loaded the fw from
adreno_load_gpu(), so drop the redundant call.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Patchwork: https://patchwork.freedesktop.org/patch/527849/
Link: https://lore.kernel.org/r/20230320144356.803762-13-robdclark@gmail.com
drivers/gpu/drm/msm/adreno/adreno_gpu.c

index d12f2f314022174083a9513f0412b3dc5767ce1e..2f70d0c3624ead601644ab5cad7c80f26fa5665c 100644 (file)
@@ -503,16 +503,9 @@ struct drm_gem_object *adreno_fw_create_bo(struct msm_gpu *gpu,
 
 int adreno_hw_init(struct msm_gpu *gpu)
 {
-       struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
-       int ret, i;
-
        VERB("%s", gpu->name);
 
-       ret = adreno_load_fw(adreno_gpu);
-       if (ret)
-               return ret;
-
-       for (i = 0; i < gpu->nr_rings; i++) {
+       for (int i = 0; i < gpu->nr_rings; i++) {
                struct msm_ringbuffer *ring = gpu->rb[i];
 
                if (!ring)