]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
ASoC: intel: skylake: Add missing break in skl_tplg_get_token()
authorTakashi Iwai <tiwai@suse.de>
Wed, 3 Oct 2018 17:31:44 +0000 (19:31 +0200)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:57:13 +0000 (19:57 -0600)
BugLink: https://bugs.launchpad.net/bugs/1836802
commit 9c80c5a8831471e0a3e139aad1b0d4c0fdc50b2f upstream.

skl_tplg_get_token() misses a break in the big switch() block for
SKL_TKN_U8_CORE_ID entry.
Spotted nicely by -Wimplicit-fallthrough compiler option.

Fixes: 6277e83292a2 ("ASoC: Intel: Skylake: Parse vendor tokens to build module data")
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
sound/soc/intel/skylake/skl-topology.c

index 81923da18ac2259ad159b8c0282242cc7c94c53c..1d484dae8a907e6299d6a3107acb7692400edf17 100644 (file)
@@ -2369,6 +2369,7 @@ static int skl_tplg_get_token(struct device *dev,
 
        case SKL_TKN_U8_CORE_ID:
                mconfig->core_id = tkn_elem->value;
+               break;
 
        case SKL_TKN_U8_MOD_TYPE:
                mconfig->m_type = tkn_elem->value;