vzdump: failed snapshot removal is non-fatal

make it more explicit (the whole call to the plugin's cleanup sub is
wrapped in an eval + warn anyway), so that future extensions can be
added after this point if they don't rely on snapshot removal being
successful.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>

diff --git a/src/PVE/VZDump/LXC.pm b/src/PVE/VZDump/LXC.pm
index 078b74d78866655969beeaf8f93391683299093c..831d64feaa5cccb4260c9726779e2f1999c5f98e 100644 (file)
--- a/src/PVE/VZDump/LXC.pm
+++ b/src/PVE/VZDump/LXC.pm
@@ -493,7 +493,8 @@ sub cleanup {
                PVE::GuestHelpers::guest_migration_lock($vmid, 600, $do_delete);
            }
        };
-       die "snapshot 'vzdump' was not (fully) removed - $@" if $@;
+       # will be cleaned up by next backup run anyway
+       warn "snapshot 'vzdump' was not (fully) removed - $@" if $@;
     }
 }