]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
ARM: dts: s5pv210: correct fuel gauge interrupt trigger level on Fascinate family
authorKrzysztof Kozlowski <krzk@kernel.org>
Thu, 10 Dec 2020 21:25:26 +0000 (22:25 +0100)
committerKelsey Skunberg <kelsey.skunberg@canonical.com>
Mon, 24 May 2021 23:46:18 +0000 (17:46 -0600)
BugLink: https://bugs.launchpad.net/bugs/1929455
[ Upstream commit 214e6ec8c9f5a3353d3282b3ff475d3ee86cc21a ]

The Maxim fuel gauge datasheets describe the interrupt line as active
low with a requirement of acknowledge from the CPU.  The falling edge
interrupt will mostly work but it's not correct.

Fixes: 99bb20321f0e ("ARM: dts: s5pv210: Correct fuelgauge definition on Aries")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20201210212534.216197-10-krzk@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
arch/arm/boot/dts/s5pv210-fascinate4g.dts

index ca064359dd308d778c522c98c68c9b22b68bb8b4..b47d8300e536ed047551ff972b52ee4e64eae5bb 100644 (file)
        compatible = "maxim,max77836-battery";
 
        interrupt-parent = <&gph3>;
-       interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
+       interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
 
        pinctrl-names = "default";
        pinctrl-0 = <&fg_irq>;