media: stm32-dcmi: fix crash when subdev do not expose any formats

BugLink: https://bugs.launchpad.net/bugs/1838700
[ Upstream commit 33dfeb62e23c31619d2197850f7e8b50e8cc5466 ]

Do not access sd_formats[] if num_of_sd_formats is zero, ie
subdev sensor didn't expose any formats.

Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>

diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c
index ac4c450a6c7d8ecb6720ab3c74515dd4aa76f7c5..9f2e6f21f6575884aa802c84e2bd98e6bc93a960 100644 (file)
--- a/drivers/media/platform/stm32/stm32-dcmi.c
+++ b/drivers/media/platform/stm32/stm32-dcmi.c
@@ -775,6 +775,9 @@ static int dcmi_try_fmt(struct stm32_dcmi *dcmi, struct v4l2_format *f,
 
        sd_fmt = find_format_by_fourcc(dcmi, pix->pixelformat);
        if (!sd_fmt) {
+               if (!dcmi->num_of_sd_formats)
+                       return -ENODATA;
+
                sd_fmt = dcmi->sd_formats[dcmi->num_of_sd_formats - 1];
                pix->pixelformat = sd_fmt->fourcc;
        }
@@ -946,6 +949,9 @@ static int dcmi_set_sensor_format(struct stm32_dcmi *dcmi,
 
        sd_fmt = find_format_by_fourcc(dcmi, pix->pixelformat);
        if (!sd_fmt) {
+               if (!dcmi->num_of_sd_formats)
+                       return -ENODATA;
+
                sd_fmt = dcmi->sd_formats[dcmi->num_of_sd_formats - 1];
                pix->pixelformat = sd_fmt->fourcc;
        }