]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
e1000e: Fix wrong comment related to link detection
authorBenjamin Poirier <bpoirier@suse.com>
Fri, 21 Jul 2017 18:36:24 +0000 (11:36 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Tue, 10 Oct 2017 15:27:07 +0000 (08:27 -0700)
Reading e1000e_check_for_copper_link() shows that get_link_status is set to
false after link has been detected. Therefore, it stays TRUE until then.

Signed-off-by: Benjamin Poirier <bpoirier@suse.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/e1000e/netdev.c

index 8436c5f2c3e818a33b8b0c3ab51dc5d874233559..ead4c112580e629af76798fee6b5ce97cf5ace9a 100644 (file)
@@ -5074,7 +5074,7 @@ static bool e1000e_has_link(struct e1000_adapter *adapter)
 
        /* get_link_status is set on LSC (link status) interrupt or
         * Rx sequence error interrupt.  get_link_status will stay
-        * false until the check_for_link establishes link
+        * true until the check_for_link establishes link
         * for copper adapters ONLY
         */
        switch (hw->phy.media_type) {
@@ -5092,7 +5092,7 @@ static bool e1000e_has_link(struct e1000_adapter *adapter)
                break;
        case e1000_media_type_internal_serdes:
                ret_val = hw->mac.ops.check_for_link(hw);
-               link_active = adapter->hw.mac.serdes_has_link;
+               link_active = hw->mac.serdes_has_link;
                break;
        default:
        case e1000_media_type_unknown: