]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
ASoC: intel: atom: localize variable without external linkage
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Tue, 2 May 2017 13:33:03 +0000 (22:33 +0900)
committerMark Brown <broonie@kernel.org>
Sun, 14 May 2017 10:00:44 +0000 (19:00 +0900)
A driver for Intel SST driver for old atom platform includes a variable
which has no external linkage. These functions should have static
qualifier.

This commit adds the qualifier to localize the variable. This issue is
detected by sparse:

sst.c:261:1: warning: symbol 'dev_attr_firmware_version' was not declared. Should it be static?

Cc: Sebastien Guiriec <sebastien.guiriec@intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/atom/sst/sst.c

index f9ba71315e335021b34aa18b4030a29b861bcac1..d97556a3772cc8377301508cb95544a1c921ef25 100644 (file)
@@ -258,7 +258,7 @@ static ssize_t firmware_version_show(struct device *dev,
 
 }
 
-DEVICE_ATTR_RO(firmware_version);
+static DEVICE_ATTR_RO(firmware_version);
 
 static const struct attribute *sst_fw_version_attrs[] = {
        &dev_attr_firmware_version.attr,