greybus: gpio: remove redundant argument verification

Remove redundant verification of gpio numbers (which have already been
verified in the gpio-chip callbacks) from greybus-operation helpers.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>

diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c
index 6a493d4758b4d817cb3f585fe110f85d13b9d5ee..a1bf1430fced29b55f60b4d5c383884437f4a1c7 100644 (file)
--- a/drivers/staging/greybus/gpio.c
+++ b/drivers/staging/greybus/gpio.c
@@ -167,9 +167,6 @@ static int gb_gpio_activate_operation(struct gb_gpio_controller *ggc, u8 which)
        struct gb_gpio_activate_request request;
        int ret;
 
-       if (which > ggc->line_max)
-               return -EINVAL;
-
        request.which = which;
        ret = gb_operation_sync(ggc->connection, GB_GPIO_TYPE_ACTIVATE,
                                 &request, sizeof(request), NULL, 0);
@@ -184,9 +181,6 @@ static int gb_gpio_deactivate_operation(struct gb_gpio_controller *ggc,
        struct gb_gpio_deactivate_request request;
        int ret;
 
-       if (which > ggc->line_max)
-               return -EINVAL;
-
        request.which = which;
        ret = gb_operation_sync(ggc->connection, GB_GPIO_TYPE_DEACTIVATE,
                                 &request, sizeof(request), NULL, 0);
@@ -203,9 +197,6 @@ static int gb_gpio_get_direction_operation(struct gb_gpio_controller *ggc,
        int ret;
        u8 direction;
 
-       if (which > ggc->line_max)
-               return -EINVAL;
-
        request.which = which;
        ret = gb_operation_sync(ggc->connection, GB_GPIO_TYPE_GET_DIRECTION,
                                &request, sizeof(request),
@@ -227,9 +218,6 @@ static int gb_gpio_direction_in_operation(struct gb_gpio_controller *ggc,
        struct gb_gpio_direction_in_request request;
        int ret;
 
-       if (which > ggc->line_max)
-               return -EINVAL;
-
        request.which = which;
        ret = gb_operation_sync(ggc->connection, GB_GPIO_TYPE_DIRECTION_IN,
                                &request, sizeof(request), NULL, 0);
@@ -244,9 +232,6 @@ static int gb_gpio_direction_out_operation(struct gb_gpio_controller *ggc,
        struct gb_gpio_direction_out_request request;
        int ret;
 
-       if (which > ggc->line_max)
-               return -EINVAL;
-
        request.which = which;
        request.value = value_high ? 1 : 0;
        ret = gb_operation_sync(ggc->connection, GB_GPIO_TYPE_DIRECTION_OUT,
@@ -264,9 +249,6 @@ static int gb_gpio_get_value_operation(struct gb_gpio_controller *ggc,
        int ret;
        u8 value;
 
-       if (which > ggc->line_max)
-               return -EINVAL;
-
        request.which = which;
        ret = gb_operation_sync(ggc->connection, GB_GPIO_TYPE_GET_VALUE,
                                &request, sizeof(request),
@@ -288,9 +270,6 @@ static int gb_gpio_set_value_operation(struct gb_gpio_controller *ggc,
        struct gb_gpio_set_value_request request;
        int ret;
 
-       if (which > ggc->line_max)
-               return -EINVAL;
-
        request.which = which;
        request.value = value_high ? 1 : 0;
        ret = gb_operation_sync(ggc->connection, GB_GPIO_TYPE_SET_VALUE,
@@ -308,9 +287,6 @@ static int gb_gpio_set_debounce_operation(struct gb_gpio_controller *ggc,
        struct gb_gpio_set_debounce_request request;
        int ret;
 
-       if (which > ggc->line_max)
-               return -EINVAL;
-
        request.which = which;
        request.usec = cpu_to_le16(debounce_usec);
        ret = gb_operation_sync(ggc->connection, GB_GPIO_TYPE_SET_DEBOUNCE,