]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
f2fs: fix to clear PG_checked flag in set_page_dirty()
authorChao Yu <yuchao0@huawei.com>
Sun, 29 Jul 2018 04:16:59 +0000 (12:16 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Fri, 10 Aug 2018 23:19:05 +0000 (16:19 -0700)
PG_checked flag will be set on data page during GC, later, we can
recognize such page by the flag and migrate page to cold segment.

But previously, we don't clear this flag when invalidating data page,
after page redirtying, we will write it into wrong log.

Let's clear PG_checked flag in set_page_dirty() to avoid this.

Signed-off-by: Weichao Guo <guoweichao@huawei.com>
Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/data.c

index 5d152de30449a4d4eb5f2ffd5536304fb262175b..b7986b2e5d1d7a419cb24c484bf07eb3d92f35d8 100644 (file)
@@ -2542,6 +2542,10 @@ static int f2fs_set_data_page_dirty(struct page *page)
        if (!PageUptodate(page))
                SetPageUptodate(page);
 
+       /* don't remain PG_checked flag which was set during GC */
+       if (is_cold_data(page))
+               clear_cold_data(page);
+
        if (f2fs_is_atomic_file(inode) && !f2fs_is_commit_atomic_write(inode)) {
                if (!IS_ATOMIC_WRITTEN_PAGE(page)) {
                        f2fs_register_inmem_page(inode, page);