]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
fsi/sbefifo: Clean up correct FIFO when receiving reset request from SBE
authorJoachim Fenkes <FENKES@de.ibm.com>
Fri, 24 Jul 2020 07:15:17 +0000 (16:45 +0930)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 13 Aug 2021 07:31:21 +0000 (09:31 +0200)
BugLink: https://bugs.launchpad.net/bugs/1938340
[ Upstream commit 95152433e46fdb36652ebdbea442356a16ae1fa6 ]

When the SBE requests a reset via the down FIFO, that is also the
FIFO we should go and reset ;)

Fixes: 9f4a8a2d7f9d ("fsi/sbefifo: Add driver for the SBE FIFO")
Signed-off-by: Joachim Fenkes <FENKES@de.ibm.com>
Signed-off-by: Joel Stanley <joel@jms.id.au>
Link: https://lore.kernel.org/r/20200724071518.430515-2-joel@jms.id.au
Signed-off-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/fsi/fsi-sbefifo.c

index bfd5e5da80209dc0f98b880aaf21df8d22103545..de27c435d706418ef34e8c811f2b68335fa9509d 100644 (file)
@@ -400,7 +400,7 @@ static int sbefifo_cleanup_hw(struct sbefifo *sbefifo)
        /* The FIFO already contains a reset request from the SBE ? */
        if (down_status & SBEFIFO_STS_RESET_REQ) {
                dev_info(dev, "Cleanup: FIFO reset request set, resetting\n");
-               rc = sbefifo_regw(sbefifo, SBEFIFO_UP, SBEFIFO_PERFORM_RESET);
+               rc = sbefifo_regw(sbefifo, SBEFIFO_DOWN, SBEFIFO_PERFORM_RESET);
                if (rc) {
                        sbefifo->broken = true;
                        dev_err(dev, "Cleanup: Reset reg write failed, rc=%d\n", rc);