]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
scsi: pm_8001: Drop PCI Wakeup calls from .resume
authorVaibhav Gupta <vaibhavgupta40@gmail.com>
Mon, 2 Nov 2020 16:47:19 +0000 (22:17 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 26 Nov 2020 04:14:51 +0000 (23:14 -0500)
The driver calls pci_enable_wake(...., false) in pm8001_pci_resume(), and
there is no corresponding pci_enable_wake(...., true) in
pm8001_pci_suspend(). Either it should do enable-wake the device in
.suspend() or should not invoke pci_enable_wake() at all.

Concluding that this driver doesn't support enable-wake and PCI core calls
pci_enable_wake(pci_dev, PCI_D0, false) during resume, drop it from
pm8001_pci__resume().

Link: https://lore.kernel.org/r/20201102164730.324035-19-vaibhavgupta40@gmail.com
Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com>
Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/pm8001/pm8001_init.c

index a6b3f1f8c806dca4ae2995c94bd19453a24b00e6..9285a9a3557dea583561b9555c02b6dbfc5992b9 100644 (file)
@@ -1322,7 +1322,6 @@ static int pm8001_pci_resume(struct pci_dev *pdev)
                      pdev, pm8001_ha->name, device_state);
 
        pci_set_power_state(pdev, PCI_D0);
-       pci_enable_wake(pdev, PCI_D0, 0);
        pci_restore_state(pdev);
        rc = pci_enable_device(pdev);
        if (rc) {