]> git.proxmox.com Git - ovs.git/commitdiff
dpdk docs: Drop file share in libvirt config.
authorTiago Lam <tiago.lam@intel.com>
Wed, 11 Apr 2018 10:25:52 +0000 (11:25 +0100)
committerIan Stokes <ian.stokes@intel.com>
Thu, 19 Apr 2018 08:34:49 +0000 (09:34 +0100)
When explaining on how to add vhost-user ports to a guest, using
libvirt, the following piece of configuration is used:
    <disk type='dir' device='disk'>
      <driver name='qemu' type='fat'/>
      <source dir='/usr/src/dpdk-stable-17.11.1'/>
      <target dev='vdb' bus='virtio'/>
      <readonly/>
    </disk>

This is used to facilitate sharing of a DPDK directory between the host
and the guest. However, for this to work selinux also needs to be
configured (or disabled).  Furthermore, if one is using Ubuntu, libvirtd
would need to be added to complain only in AppArmor. Instead, in [1] it
is advised to use wget to get the DPDK sources over the internet, which
avoids this differentiation. Thus, we drop this piece of configuration
here as well and keep the example configuration as simple as possible.

This has been verified on both a Fedora 27 image and a Ubuntu 16.04 LTS
image.

[1] http://docs.openvswitch.org/en/latest/topics/dpdk/vhost-user/#dpdk-in-the-guest

Signed-off-by: Tiago Lam <tiago.lam@intel.com>
Acked-by: Stephen Finucane <stephen@that.guru>
Signed-off-by: Ian Stokes <ian.stokes@intel.com>
Documentation/topics/dpdk/vhost-user.rst

index 74bab78dc290b7504ee22d34a52bb690ad4c310a..6bf16f72ba2d16ecd20fadf485c7ae34eafbb7a7 100644 (file)
@@ -187,21 +187,14 @@ where:
 Adding vhost-user ports to the guest (libvirt)
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-.. TODO(stephenfin): This seems like something that wouldn't be acceptable in
-   production. Is this really required?
-
-To begin, you must change the user and group that libvirt runs under, configure
-access control policy and restart libvirtd.
+To begin, you must change the user and group that qemu runs under, and restart
+libvirtd.
 
 - In ``/etc/libvirt/qemu.conf`` add/edit the following lines::
 
       user = "root"
       group = "root"
 
-- Disable SELinux or set to permissive mode::
-
-      $ setenforce 0
-
 - Finally, restart the libvirtd process, For example, on Fedora::
 
       $ systemctl restart libvirtd.service
@@ -407,12 +400,6 @@ Sample XML
           <source file='/root/CentOS7_x86_64.qcow2'/>
           <target dev='vda' bus='virtio'/>
         </disk>
-        <disk type='dir' device='disk'>
-          <driver name='qemu' type='fat'/>
-          <source dir='/usr/src/dpdk-stable-17.11.1'/>
-          <target dev='vdb' bus='virtio'/>
-          <readonly/>
-        </disk>
         <interface type='vhostuser'>
           <mac address='00:00:00:00:00:01'/>
           <source type='unix' path='/usr/local/var/run/openvswitch/dpdkvhostuser0' mode='client'/>