]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
s390/lcs: fix variable dereferenced before check
authorAlexandra Winter <wintera@linux.ibm.com>
Tue, 10 May 2022 07:05:08 +0000 (09:05 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 11 May 2022 11:31:01 +0000 (12:31 +0100)
smatch complains about
drivers/s390/net/lcs.c:1741 lcs_get_control() warn: variable dereferenced before check 'card->dev' (see line 1739)

Fixes: 27eb5ac8f015 ("[PATCH] s390: lcs driver bug fixes and improvements [1/2]")
Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/lcs.c

index bab9b34926c6881d1388e6c328aa704b58868613..84c8981317b4602a2695f8eb29f67288eaeceecd 100644 (file)
@@ -1736,10 +1736,11 @@ lcs_get_control(struct lcs_card *card, struct lcs_cmd *cmd)
                        lcs_schedule_recovery(card);
                        break;
                case LCS_CMD_STOPLAN:
-                       pr_warn("Stoplan for %s initiated by LGW\n",
-                               card->dev->name);
-                       if (card->dev)
+                       if (card->dev) {
+                               pr_warn("Stoplan for %s initiated by LGW\n",
+                                       card->dev->name);
                                netif_carrier_off(card->dev);
+                       }
                        break;
                default:
                        LCS_DBF_TEXT(5, trace, "noLGWcmd");