]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
perf c2c: Display proper cpu count in nodes column
authorJiri Olsa <jolsa@kernel.org>
Tue, 20 Aug 2019 14:02:19 +0000 (16:02 +0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 29 Aug 2019 20:38:31 +0000 (17:38 -0300)
There's wrong bitmap considered when checking for cpu count of specific
node.

We do the needed computation for 'set' variable, but at the end we use
the 'c2c_he->cpuset' weight, which shows misleading numbers.

Fixes: 1e181b92a2da ("perf c2c report: Add 'node' sort key")
Reported-by: Joe Mario <jmario@redhat.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Michael Petlan <mpetlan@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20190820140219.28338-1-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-c2c.c

index 73782d99ee5a0f47ecd2ccb9ea75844f3b52a106..8335a4076a5af718a05da88e8e38f4bad234efdc 100644 (file)
@@ -1107,7 +1107,7 @@ node_entry(struct perf_hpp_fmt *fmt __maybe_unused, struct perf_hpp *hpp,
                        break;
                case 1:
                {
-                       int num = bitmap_weight(c2c_he->cpuset, c2c.cpus_cnt);
+                       int num = bitmap_weight(set, c2c.cpus_cnt);
                        struct c2c_stats *stats = &c2c_he->node_stats[node];
 
                        ret = scnprintf(hpp->buf, hpp->size, "%2d{%2d ", node, num);