]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
net: enetc: recycle buffers for frames with RX errors
authorVladimir Oltean <vladimir.oltean@nxp.com>
Fri, 16 Apr 2021 21:22:18 +0000 (00:22 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sat, 17 Apr 2021 00:08:39 +0000 (17:08 -0700)
When receiving a frame with errors, currently we do nothing with it (we
don't construct an skb or an xdp_buff), we just exit the NAPI poll loop.

Let's put the buffer back into the RX ring (similar to XDP_DROP).

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/enetc/enetc.c

index c4ff090f29ec652d8314d02b1eff482232e63329..c6f98447333752a05aa0c0aac1ac5f1e06da5d4c 100644 (file)
@@ -822,12 +822,14 @@ static bool enetc_check_bd_errors_and_consume(struct enetc_bdr *rx_ring,
        if (likely(!(bd_status & ENETC_RXBD_LSTATUS(ENETC_RXBD_ERR_MASK))))
                return false;
 
+       enetc_put_rx_buff(rx_ring, &rx_ring->rx_swbd[*i]);
        enetc_rxbd_next(rx_ring, rxbd, i);
 
        while (!(bd_status & ENETC_RXBD_LSTATUS_F)) {
                dma_rmb();
                bd_status = le32_to_cpu((*rxbd)->r.lstatus);
 
+               enetc_put_rx_buff(rx_ring, &rx_ring->rx_swbd[*i]);
                enetc_rxbd_next(rx_ring, rxbd, i);
        }