]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
usb: typec: tcpm: move to SNK_UNATTACHED if sink removed for DRP
authorLi Jun <jun.li@nxp.com>
Wed, 19 Feb 2020 16:05:43 +0000 (00:05 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Mar 2020 09:51:21 +0000 (10:51 +0100)
Per typec spec:
Figure 4-15 Connection State Diagram: DRP
Figure 4-16 Connection State Diagram: DRP with Accessory and Try.SRC
    Support
Figure 4-17 Connection State Diagram: DRP with Accessory and Try.SNK
    Support
DRP port should move to Unattached.SNK instead of Unattached.SRC if
sink removed.

Signed-off-by: Li Jun <jun.li@nxp.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/1582128343-22438-1-git-send-email-jun.li@nxp.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/tcpm/tcpm.c

index bc0032a6b9a147840f0da897924317c4422a91b0..de3576e6530ab2abdd9dc07a4c4c88b51521f0ca 100644 (file)
@@ -3680,8 +3680,12 @@ static void _tcpm_cc_change(struct tcpm_port *port, enum typec_cc_status cc1,
        case SRC_SEND_CAPABILITIES:
        case SRC_READY:
                if (tcpm_port_is_disconnected(port) ||
-                   !tcpm_port_is_source(port))
-                       tcpm_set_state(port, SRC_UNATTACHED, 0);
+                   !tcpm_port_is_source(port)) {
+                       if (port->port_type == TYPEC_PORT_SRC)
+                               tcpm_set_state(port, SRC_UNATTACHED, 0);
+                       else
+                               tcpm_set_state(port, SNK_UNATTACHED, 0);
+               }
                break;
        case SNK_UNATTACHED:
                if (tcpm_port_is_sink(port))